[이수현] 휴대폰 인증 API #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunJongHun
reviewed
Nov 26, 2023
|
|
||
| /** SMS 인증 */ | ||
| @Post('signin/:code') | ||
| @HttpCode(HttpStatus.OK) |
There was a problem hiding this comment.
상태 코드 반환을 HttpStatus 객체를 통해 반환할 수 있군요👍
저는 200, 400 이렇게 써서 보냈었는데.. 훨씬 명시적이라 좋습니다! 알아갑니다😄
Comment on lines
+58
to
+66
| const smsCode = await this.authRepository.findOne({ | ||
| where: { phone }, | ||
| }); | ||
|
|
||
| if (!smsCode || smsCode.expires < Date.now()) { | ||
| throw new UnauthorizedException( | ||
| '인증 시간이 만료되었습니다. 다시 시도해 주세요.', | ||
| ); | ||
| } |
There was a problem hiding this comment.
smsCode 변수를 보고 인증 번호를 가져오는 줄 알았어요! 변수명이 명시적이면 좋을 것 같아요😄
if (!smsCode || smsCode.expires < Date.now()) 에서 핸드폰 번호가 없을 때도 '인증 시간이 만료' 로 메세지가 날라가는데, 예외처리를 분리하면 좋겠다는 생각이 드네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.